[Differential] [Requested Changes To] D4227: Don't block when running the post-install command

Marco Martin noreply at phabricator.kde.org
Mon Jan 23 12:01:08 UTC 2017


mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> installation.h:137
>      QStringList installDownloadedFileAndUncompress(const KNSCore::EntryInternal  &entry, const QString &payloadfile, const QString installdir);
> -    void runPostInstallationCommand(const QString &installPath);
> +    QProcess* runPostInstallationCommand(const QString &installPath);
>  

BIC
even if the api of this file is beyond terrible, unfortunately it's exported, so no binary incompatible changes should occur

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D4227

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, whiting, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170123/4d468260/attachment.html>


More information about the Kde-frameworks-devel mailing list