[Differential] [Request, 102 lines] D4082: parse the desktop file 2 times
Marco Martin
noreply at phabricator.kde.org
Wed Jan 11 12:55:05 UTC 2017
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Search for the ServiceTypes key in the desktop file before
parsing it "for real", because how it's parsed depends from
the service type definition, so if the servicetype is defined
at the bottom of the file or after keys dependent from the type,
those keys would be parsed incorrectly
TEST PLAN
things using plugins like plasmashell still start correctly,
dropping on the desktop a text file now proposes to create a notes widget.
The notes widget has ServiceTypes defined *after* X-Plasma-DropMimetypes
which is a stringlist, that would be misinterpreted as a string
otherwise
REPOSITORY
R244 KCoreAddons
BRANCH
phab/prse2servicetypes
REVISION DETAIL
https://phabricator.kde.org/D4082
AFFECTED FILES
src/lib/plugin/desktopfileparser.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: mart, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170111/2488763b/attachment.html>
More information about the Kde-frameworks-devel
mailing list