[Differential] [Commented On] D4082: parse the desktop file 2 times

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> desktopfileparser.cpp:237
>  
> +bool tokenizeKeyValue(QFile &df, const QString &src, QByteArray &key, QString &value, int &lineNr)
> +{

maybe instead a bool it could have error codes to more easily assure the behavior is 100% the same as before

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4082

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson, dfaure
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170111/e8ae7542/attachment.html>