Review Request 129713: Only try to open the file if it's not empty

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jan 10 01:40:52 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129713/
-----------------------------------------------------------

(Updated Jan. 10, 2017, 1:40 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Frameworks and Jeremy Whiting.


Changes
-------

Submitted with commit a646f28964490b8b2dd0757e5b5b63cacb2986b4 by Aleix Pol on behalf of Aleix Pol Gonzalez to branch master.


Repository: knewstuff


Description
-------

The filename will (always?) be empty, this would end up in an error such as `QFSFileEngine::open: No file name specified`.
This patch prevents the code path.


Diffs
-----

  src/core/security.cpp e9f3ee0 

Diff: https://git.reviewboard.kde.org/r/129713/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170110/4f7f9cdf/attachment.html>


More information about the Kde-frameworks-devel mailing list