Review Request 129713: Only try to open the file if it's not empty

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129713/#review101893
-----------------------------------------------------------


Ship it!




Ship It!

- David Faure


On Dec. 28, 2016, 3:02 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129713/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2016, 3:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> -------
> 
> The filename will (always?) be empty, this would end up in an error such as `QFSFileEngine::open: No file name specified`.
> This patch prevents the code path.
> 
> 
> Diffs
> -----
> 
>   src/core/security.cpp e9f3ee0 
> 
> Diff: https://git.reviewboard.kde.org/r/129713/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170108/efcb700e/attachment-0001.html>