[Differential] [Changed Subscribers] D4019: [ToolTipDialog] Use KWindowSystem::isPlatformX11() which is cached

[markg (Mark Gaiser)]

markg added inline comments.

INLINE COMMENTS

> tooltipdialog.cpp:116-118
> +    if (KWindowSystem::isPlatformX11()) {
>          flags = flags | Qt::BypassWindowManagerHint;
>      }

Isn't this redundant anyway?
It's being set in the constructor as well.

The constructor only deviates in initial flags (it doesn't explicitly set Qt::WindowDoesNotAcceptFocus | Qt::WindowStaysOnTopHint). Hmm, if you add these flags to the constructor (don't know if that is allowed) then you can just call "return Dialog::event(e);" after the #endif.

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D4019

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: markg, plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170108/ca33be28/attachment.html>