<table><tr><td style="">markg added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4019" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D4019#inline-15871" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tooltipdialog.cpp:116-118</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"><span class="bright"></span><span style="color: #304a96"><span class="bright">#if HAVE_X11</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">QX11Info</span><span style="color: #aa2211">::</span><span class="n">isPlatformX11</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="bright">    </span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">KWindowSystem</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">isPlatformX11</span></span><span class="bright"></span><span class="p"><span class="bright">())</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">flags</span> <span style="color: #aa2211">=</span> <span class="n">flags</span> <span style="color: #aa2211">|</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">BypassWindowManagerHint</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;"><span style="color: #304a96">#endif</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Isn't this redundant anyway?<br />
It's being set in the constructor as well.</p>

<p style="padding: 0; margin: 8px;">The constructor only deviates in initial flags (it doesn't explicitly set Qt::WindowDoesNotAcceptFocus | Qt::WindowStaysOnTopHint). Hmm, if you add these flags to the constructor (don't know if that is allowed) then you can just call "return Dialog::event(e);" after the #endif.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Frameworks</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4019" rel="noreferrer">https://phabricator.kde.org/D4019</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidedmundson<br /><strong>Cc: </strong>markg, plasma-devel, Frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas<br /></div>