[Differential] [Request, 2,027 lines] D3987: Use nullptr in all Frameworks (just diff in KIO shown here)
kfunk (Kevin Funk)
noreply at phabricator.kde.org
Thu Jan 5 23:44:15 UTC 2017
kfunk created this revision.
kfunk added a reviewer: Frameworks.
kfunk set the repository for this revision to R241 KIO.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The full patch (all Frameworks ported to using nullptr instead of null literals) changes around 9000 lines in total:
This is what I use locally to keep track of my changes:
% kde-frameworks-list.sh | xargs -n1 -I% sh -c "(cd %; git-difflinesonly.sh)" | head
-Code39Barcode::Code39Barcode() : AbstractBarcode(), d(0){
+Code39Barcode::Code39Barcode() : AbstractBarcode(), d(nullptr){
-Code93Barcode::Code93Barcode() : AbstractBarcode(), d(0){
+Code93Barcode::Code93Barcode() : AbstractBarcode(), d(nullptr){
-DataMatrixBarcode::DataMatrixBarcode() : d(0) {
+DataMatrixBarcode::DataMatrixBarcode() : d(nullptr) {
-QRCodeBarcode::QRCodeBarcode() : AbstractBarcode(), d(0){
+QRCodeBarcode::QRCodeBarcode() : AbstractBarcode(), d(nullptr){
- BarcodeExampleWidget(Prison::AbstractBarcode* barcode, QWidget* parent=0);
+ BarcodeExampleWidget(Prison::AbstractBarcode* barcode, QWidget* parent=nullptr);
% kde-frameworks-list.sh | xargs -n1 -I% sh -c "(cd %; git-difflinesonly.sh)" | wc -l
18592
> ~9000 lines changed.
======================
This change affects *all files*. Not just headers.
There are more options to limit the number of changes:
- Less changes: Just change headers (.h files) -- easy
- Even less changes: Just change public headers -- slightly more difficult for me to figure out *what* is public from a scripting POV
If you think we should limit our changes, please speak up. I wouldn't recommend it though. Let's move forward instead.
My plan was to push this after the next KF5 release.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D3987
AFFECTED FILES
autotests/clipboardupdatertest.cpp
autotests/deletejobtest.cpp
autotests/dropjobtest.cpp
autotests/fileundomanagertest.cpp
autotests/http/httpauthenticationtest.cpp
autotests/http_jobtest.cpp
autotests/httpserver_p.h
autotests/jobguitest.cpp
autotests/jobremotetest.cpp
autotests/jobtest.cpp
autotests/kcookiejar/kcookiejartest.cpp
autotests/kdirlistertest.cpp
autotests/kdirmodeltest.cpp
autotests/kfilecopytomenutest.cpp
autotests/kfilewidgettest.cpp
autotests/klocalsockettest.cpp
autotests/knewfilemenutest.cpp
autotests/krununittest.cpp
autotests/ktcpsockettest.cpp
autotests/kurifiltersearchprovideractionstest.cpp
autotests/kurifiltertest.cpp
autotests/kurlcompletiontest.cpp
autotests/kurlnavigatortest.cpp
autotests/listdirtest.cpp
autotests/mkpathjobtest.cpp
autotests/pastetest.cpp
autotests/threadtest.cpp
src/core/authinfo.cpp
src/core/chmodjob.cpp
src/core/connection.cpp
src/core/connection_p.h
src/core/connectionbackend.cpp
src/core/connectionbackend_p.h
src/core/connectionserver.cpp
src/core/connectionserver.h
src/core/copyjob.cpp
src/core/dataprotocol.cpp
src/core/deletejob.cpp
src/core/filecopyjob.cpp
src/core/forwardingslavebase.cpp
src/core/hostinfo.cpp
src/core/job.cpp
src/core/job.h
src/core/job_base.h
src/core/job_error.cpp
src/core/job_p.h
src/core/jobtracker.cpp
src/core/jobuidelegateextension.cpp
src/core/jobuidelegatefactory.cpp
src/core/kacl.cpp
src/core/kcoredirlister.cpp
src/core/kcoredirlister.h
src/core/kcoredirlister_p.h
src/core/kdirnotify.h
src/core/kfileitem.cpp
src/core/kfileitem.h
src/core/klocalsocket.cpp
src/core/klocalsocket.h
src/core/klocalsocket_unix.cpp
src/core/kmountpoint.cpp
src/core/kprotocolmanager.cpp
src/core/krecentdocument.cpp
src/core/kremoteencoding.cpp
src/core/kremoteencoding.h
src/core/ksambashare.cpp
src/core/ksslcertificatemanager.cpp
src/core/kssld_interface.h
src/core/ktcpsocket.h
src/core/scheduler.cpp
src/core/scheduler_p.h
src/core/simplejob.cpp
src/core/slave.cpp
src/core/slave.h
src/core/slavebase.cpp
src/core/slavebase.h
src/core/slaveconfig.cpp
src/core/slaveinterface.h
src/core/slaveinterface_p.h
src/core/storedtransferjob.cpp
src/core/tcpslavebase.h
src/core/transferjob.cpp
src/core/usernotificationhandler.cpp
src/core/usernotificationhandler_p.h
src/filewidgets/kdiroperator.cpp
src/filewidgets/kdiroperator.h
src/filewidgets/kdiroperatordetailview_p.h
src/filewidgets/kdirsortfilterproxymodel.h
src/filewidgets/kencodingfiledialog.h
src/filewidgets/kfilecopytomenu.cpp
src/filewidgets/kfilefiltercombo.h
src/filewidgets/kfilemetapreview.cpp
src/filewidgets/kfileplaceeditdialog.cpp
src/filewidgets/kfileplaceeditdialog.h
src/filewidgets/kfileplacesitem.cpp
src/filewidgets/kfileplacesitem_p.h
src/filewidgets/kfileplacesmodel.cpp
src/filewidgets/kfileplacesmodel.h
src/filewidgets/kfileplacesview.cpp
src/filewidgets/kfileplacesview.h
src/filewidgets/kfileplacesview_p.h
src/filewidgets/kfilepreviewgenerator.cpp
src/filewidgets/kfilewidget.cpp
src/filewidgets/kfilewidget.h
src/filewidgets/kimagefilepreview.cpp
src/filewidgets/kimagefilepreview.h
src/filewidgets/knewfilemenu.cpp
src/filewidgets/kurlnavigator.cpp
src/filewidgets/kurlnavigator.h
src/filewidgets/kurlnavigatorbutton.cpp
src/filewidgets/kurlnavigatormenu.cpp
src/filewidgets/kurlnavigatorplacesselector.cpp
src/filewidgets/kurlnavigatorprotocolcombo.cpp
src/filewidgets/kurlnavigatorprotocolcombo_p.h
src/ioslaves/file/file.cpp
src/ioslaves/file/file_unix.cpp
src/ioslaves/ftp/ftp.cpp
src/ioslaves/ftp/ftp.h
src/ioslaves/help/kio_help.cpp
src/ioslaves/http/http.cpp
src/ioslaves/http/http.h
src/ioslaves/http/http_cache_cleaner.cpp
src/ioslaves/http/httpauthentication.cpp
src/ioslaves/http/httpauthentication.h
src/ioslaves/http/httpfilter.cpp
src/ioslaves/http/kcookiejar/kcookiejar.cpp
src/ioslaves/http/kcookiejar/kcookiejar.h
src/ioslaves/http/kcookiejar/kcookieserver.cpp
src/ioslaves/http/kcookiejar/kcookieserver.h
src/ioslaves/http/kcookiejar/kcookiewin.h
src/ioslaves/telnet/ktelnetservice.cpp
src/ioslaves/trash/kcmtrash.cpp
src/ioslaves/trash/kio_trash.cpp
src/ioslaves/trash/tests/testtrash.cpp
src/ioslaves/trash/trashimpl.cpp
src/kcms/kio/kcookiesmain.cpp
src/kcms/kio/kcookiesmanagement.cpp
src/kcms/kio/kcookiespolicies.cpp
src/kcms/kio/kcookiespolicyselectiondlg.cpp
src/kcms/kio/kcookiespolicyselectiondlg.h
src/kcms/kio/kproxydlg.cpp
src/kcms/kio/ksaveioconfig.cpp
src/kcms/kio/ksaveioconfig.h
src/kcms/kio/useragentdlg.cpp
src/kcms/kio/useragentselectordlg.cpp
src/kcms/kio/useragentselectordlg.h
src/kcms/webshortcuts/main.cpp
src/kiod/kiod_main.cpp
src/kpac/proxyscout.cpp
src/kpac/script.cpp
src/kpasswdserver/kpasswdserver.cpp
src/urifilters/ikws/ikwsopts.cpp
src/urifilters/ikws/ikwsopts.h
src/urifilters/ikws/ikwsopts_p.h
src/urifilters/ikws/kuriikwsfilter.h
src/urifilters/ikws/kuriikwsfiltereng.cpp
src/urifilters/ikws/kurisearchfilter.h
src/urifilters/ikws/searchprovider.cpp
src/urifilters/ikws/searchproviderdlg.cpp
src/urifilters/ikws/searchproviderdlg.h
src/urifilters/shorturi/kshorturifilter.cpp
src/urifilters/shorturi/kshorturifilter.h
src/widgets/accessmanager.cpp
src/widgets/accessmanager.h
src/widgets/accessmanagerreply_p.h
src/widgets/delegateanimationhandler.cpp
src/widgets/delegateanimationhandler_p.h
src/widgets/dropjob.cpp
src/widgets/executablefileopendialog_p.h
src/widgets/fileundomanager.cpp
src/widgets/jobuidelegate.cpp
src/widgets/joburlcache.cpp
src/widgets/kacleditwidget.cpp
src/widgets/kacleditwidget.h
src/widgets/kacleditwidget_p.h
src/widgets/kautomount.cpp
src/widgets/kdesktopfileactions.cpp
src/widgets/kdirlister.cpp
src/widgets/kdirlister.h
src/widgets/kdirmodel.cpp
src/widgets/kdirmodel.h
src/widgets/kdynamicjobtracker.cpp
src/widgets/kdynamicjobtracker_p.h
src/widgets/kfileitemactions.cpp
src/widgets/kfileitemactions.h
src/widgets/kfileitemdelegate.cpp
src/widgets/kfileitemdelegate.h
src/widgets/kopenwithdialog.cpp
src/widgets/kopenwithdialog.h
src/widgets/kopenwithdialog_p.h
src/widgets/kpropertiesdialog.cpp
src/widgets/kpropertiesdialog.h
src/widgets/krun.cpp
src/widgets/ksslcertificatebox.h
src/widgets/ksslinfodialog.h
src/widgets/kurifilter.cpp
src/widgets/kurifilter.h
src/widgets/kurlcombobox.cpp
src/widgets/kurlcombobox.h
src/widgets/kurlcompletion.cpp
src/widgets/kurlpixmapprovider.cpp
src/widgets/kurlrequester.cpp
src/widgets/kurlrequester.h
src/widgets/kurlrequesterdialog.h
src/widgets/paste.cpp
src/widgets/pastejob.cpp
src/widgets/pixmaploader.h
src/widgets/previewjob.cpp
src/widgets/previewjob.h
src/widgets/renamedialog.cpp
src/widgets/skipdialog.cpp
src/widgets/sslui.cpp
src/widgets/thumbcreator.cpp
tests/kdirlistertest_gui.cpp
tests/kdirlistertest_gui.h
tests/kdirmodeltest_gui.cpp
tests/kioslavetest.cpp
tests/kopenwithtest.cpp
tests/kruntest.cpp
tests/ksycocaupdatetest.cpp
tests/kurlnavigatortest_gui.cpp
tests/listjobtest.cpp
tests/listrecursivetest.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170105/d254238e/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list