<table><tr><td style="">kfunk created this revision.<br />kfunk added a reviewer: Frameworks.<br />kfunk set the repository for this revision to R241 KIO.<br />Restricted Application added a project: Frameworks.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3987" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The full patch (all Frameworks ported to using nullptr instead of null literals) changes around 9000 lines in total:</p>

<p>This is what I use locally to keep track of my changes:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">% kde-frameworks-list.sh  | xargs -n1 -I% sh -c "(cd %; git-difflinesonly.sh)" | head

-Code39Barcode::Code39Barcode() : AbstractBarcode(), d(0){

+Code39Barcode::Code39Barcode() : AbstractBarcode(), d(nullptr){

-Code93Barcode::Code93Barcode() : AbstractBarcode(), d(0){

+Code93Barcode::Code93Barcode() : AbstractBarcode(), d(nullptr){

-DataMatrixBarcode::DataMatrixBarcode() : d(0) {

+DataMatrixBarcode::DataMatrixBarcode() : d(nullptr) {

-QRCodeBarcode::QRCodeBarcode() : AbstractBarcode(), d(0){

+QRCodeBarcode::QRCodeBarcode() : AbstractBarcode(), d(nullptr){

-    BarcodeExampleWidget(Prison::AbstractBarcode* barcode, QWidget* parent=0);

+    BarcodeExampleWidget(Prison::AbstractBarcode* barcode, QWidget* parent=nullptr);

% kde-frameworks-list.sh  | xargs -n1 -I% sh -c "(cd %; git-difflinesonly.sh)" | wc -l

18592</pre></div>

<h2 class="remarkup-header">> ~9000 lines changed.</h2>

<p>This change affects *all files*. Not just headers.</p>

<p>There are more options to limit  the number of changes:</p>

<ul class="remarkup-list">

<li class="remarkup-list-item">Less changes: Just change headers (.h files) -- easy</li>

<li class="remarkup-list-item">Even less changes: Just change public headers -- slightly more difficult for me to figure out *what* is public from a scripting POV</li>

</ul>

<p>If you think we should limit our changes, please speak up. I wouldn't recommend it though. Let's move forward instead.</p>

<p>My plan was to push this after the next KF5 release.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3987" rel="noreferrer">https://phabricator.kde.org/D3987</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/clipboardupdatertest.cpp<br />

autotests/deletejobtest.cpp<br />

autotests/dropjobtest.cpp<br />

autotests/fileundomanagertest.cpp<br />

autotests/http/httpauthenticationtest.cpp<br />

autotests/http_jobtest.cpp<br />

autotests/httpserver_p.h<br />

autotests/jobguitest.cpp<br />

autotests/jobremotetest.cpp<br />

autotests/jobtest.cpp<br />

autotests/kcookiejar/kcookiejartest.cpp<br />

autotests/kdirlistertest.cpp<br />

autotests/kdirmodeltest.cpp<br />

autotests/kfilecopytomenutest.cpp<br />

autotests/kfilewidgettest.cpp<br />

autotests/klocalsockettest.cpp<br />

autotests/knewfilemenutest.cpp<br />

autotests/krununittest.cpp<br />

autotests/ktcpsockettest.cpp<br />

autotests/kurifiltersearchprovideractionstest.cpp<br />

autotests/kurifiltertest.cpp<br />

autotests/kurlcompletiontest.cpp<br />

autotests/kurlnavigatortest.cpp<br />

autotests/listdirtest.cpp<br />

autotests/mkpathjobtest.cpp<br />

autotests/pastetest.cpp<br />

autotests/threadtest.cpp<br />

src/core/authinfo.cpp<br />

src/core/chmodjob.cpp<br />

src/core/connection.cpp<br />

src/core/connection_p.h<br />

src/core/connectionbackend.cpp<br />

src/core/connectionbackend_p.h<br />

src/core/connectionserver.cpp<br />

src/core/connectionserver.h<br />

src/core/copyjob.cpp<br />

src/core/dataprotocol.cpp<br />

src/core/deletejob.cpp<br />

src/core/filecopyjob.cpp<br />

src/core/forwardingslavebase.cpp<br />

src/core/hostinfo.cpp<br />

src/core/job.cpp<br />

src/core/job.h<br />

src/core/job_base.h<br />

src/core/job_error.cpp<br />

src/core/job_p.h<br />

src/core/jobtracker.cpp<br />

src/core/jobuidelegateextension.cpp<br />

src/core/jobuidelegatefactory.cpp<br />

src/core/kacl.cpp<br />

src/core/kcoredirlister.cpp<br />

src/core/kcoredirlister.h<br />

src/core/kcoredirlister_p.h<br />

src/core/kdirnotify.h<br />

src/core/kfileitem.cpp<br />

src/core/kfileitem.h<br />

src/core/klocalsocket.cpp<br />

src/core/klocalsocket.h<br />

src/core/klocalsocket_unix.cpp<br />

src/core/kmountpoint.cpp<br />

src/core/kprotocolmanager.cpp<br />

src/core/krecentdocument.cpp<br />

src/core/kremoteencoding.cpp<br />

src/core/kremoteencoding.h<br />

src/core/ksambashare.cpp<br />

src/core/ksslcertificatemanager.cpp<br />

src/core/kssld_interface.h<br />

src/core/ktcpsocket.h<br />

src/core/scheduler.cpp<br />

src/core/scheduler_p.h<br />

src/core/simplejob.cpp<br />

src/core/slave.cpp<br />

src/core/slave.h<br />

src/core/slavebase.cpp<br />

src/core/slavebase.h<br />

src/core/slaveconfig.cpp<br />

src/core/slaveinterface.h<br />

src/core/slaveinterface_p.h<br />

src/core/storedtransferjob.cpp<br />

src/core/tcpslavebase.h<br />

src/core/transferjob.cpp<br />

src/core/usernotificationhandler.cpp<br />

src/core/usernotificationhandler_p.h<br />

src/filewidgets/kdiroperator.cpp<br />

src/filewidgets/kdiroperator.h<br />

src/filewidgets/kdiroperatordetailview_p.h<br />

src/filewidgets/kdirsortfilterproxymodel.h<br />

src/filewidgets/kencodingfiledialog.h<br />

src/filewidgets/kfilecopytomenu.cpp<br />

src/filewidgets/kfilefiltercombo.h<br />

src/filewidgets/kfilemetapreview.cpp<br />

src/filewidgets/kfileplaceeditdialog.cpp<br />

src/filewidgets/kfileplaceeditdialog.h<br />

src/filewidgets/kfileplacesitem.cpp<br />

src/filewidgets/kfileplacesitem_p.h<br />

src/filewidgets/kfileplacesmodel.cpp<br />

src/filewidgets/kfileplacesmodel.h<br />

src/filewidgets/kfileplacesview.cpp<br />

src/filewidgets/kfileplacesview.h<br />

src/filewidgets/kfileplacesview_p.h<br />

src/filewidgets/kfilepreviewgenerator.cpp<br />

src/filewidgets/kfilewidget.cpp<br />

src/filewidgets/kfilewidget.h<br />

src/filewidgets/kimagefilepreview.cpp<br />

src/filewidgets/kimagefilepreview.h<br />

src/filewidgets/knewfilemenu.cpp<br />

src/filewidgets/kurlnavigator.cpp<br />

src/filewidgets/kurlnavigator.h<br />

src/filewidgets/kurlnavigatorbutton.cpp<br />

src/filewidgets/kurlnavigatormenu.cpp<br />

src/filewidgets/kurlnavigatorplacesselector.cpp<br />

src/filewidgets/kurlnavigatorprotocolcombo.cpp<br />

src/filewidgets/kurlnavigatorprotocolcombo_p.h<br />

src/ioslaves/file/file.cpp<br />

src/ioslaves/file/file_unix.cpp<br />

src/ioslaves/ftp/ftp.cpp<br />

src/ioslaves/ftp/ftp.h<br />

src/ioslaves/help/kio_help.cpp<br />

src/ioslaves/http/http.cpp<br />

src/ioslaves/http/http.h<br />

src/ioslaves/http/http_cache_cleaner.cpp<br />

src/ioslaves/http/httpauthentication.cpp<br />

src/ioslaves/http/httpauthentication.h<br />

src/ioslaves/http/httpfilter.cpp<br />

src/ioslaves/http/kcookiejar/kcookiejar.cpp<br />

src/ioslaves/http/kcookiejar/kcookiejar.h<br />

src/ioslaves/http/kcookiejar/kcookieserver.cpp<br />

src/ioslaves/http/kcookiejar/kcookieserver.h<br />

src/ioslaves/http/kcookiejar/kcookiewin.h<br />

src/ioslaves/telnet/ktelnetservice.cpp<br />

src/ioslaves/trash/kcmtrash.cpp<br />

src/ioslaves/trash/kio_trash.cpp<br />

src/ioslaves/trash/tests/testtrash.cpp<br />

src/ioslaves/trash/trashimpl.cpp<br />

src/kcms/kio/kcookiesmain.cpp<br />

src/kcms/kio/kcookiesmanagement.cpp<br />

src/kcms/kio/kcookiespolicies.cpp<br />

src/kcms/kio/kcookiespolicyselectiondlg.cpp<br />

src/kcms/kio/kcookiespolicyselectiondlg.h<br />

src/kcms/kio/kproxydlg.cpp<br />

src/kcms/kio/ksaveioconfig.cpp<br />

src/kcms/kio/ksaveioconfig.h<br />

src/kcms/kio/useragentdlg.cpp<br />

src/kcms/kio/useragentselectordlg.cpp<br />

src/kcms/kio/useragentselectordlg.h<br />

src/kcms/webshortcuts/main.cpp<br />

src/kiod/kiod_main.cpp<br />

src/kpac/proxyscout.cpp<br />

src/kpac/script.cpp<br />

src/kpasswdserver/kpasswdserver.cpp<br />

src/urifilters/ikws/ikwsopts.cpp<br />

src/urifilters/ikws/ikwsopts.h<br />

src/urifilters/ikws/ikwsopts_p.h<br />

src/urifilters/ikws/kuriikwsfilter.h<br />

src/urifilters/ikws/kuriikwsfiltereng.cpp<br />

src/urifilters/ikws/kurisearchfilter.h<br />

src/urifilters/ikws/searchprovider.cpp<br />

src/urifilters/ikws/searchproviderdlg.cpp<br />

src/urifilters/ikws/searchproviderdlg.h<br />

src/urifilters/shorturi/kshorturifilter.cpp<br />

src/urifilters/shorturi/kshorturifilter.h<br />

src/widgets/accessmanager.cpp<br />

src/widgets/accessmanager.h<br />

src/widgets/accessmanagerreply_p.h<br />

src/widgets/delegateanimationhandler.cpp<br />

src/widgets/delegateanimationhandler_p.h<br />

src/widgets/dropjob.cpp<br />

src/widgets/executablefileopendialog_p.h<br />

src/widgets/fileundomanager.cpp<br />

src/widgets/jobuidelegate.cpp<br />

src/widgets/joburlcache.cpp<br />

src/widgets/kacleditwidget.cpp<br />

src/widgets/kacleditwidget.h<br />

src/widgets/kacleditwidget_p.h<br />

src/widgets/kautomount.cpp<br />

src/widgets/kdesktopfileactions.cpp<br />

src/widgets/kdirlister.cpp<br />

src/widgets/kdirlister.h<br />

src/widgets/kdirmodel.cpp<br />

src/widgets/kdirmodel.h<br />

src/widgets/kdynamicjobtracker.cpp<br />

src/widgets/kdynamicjobtracker_p.h<br />

src/widgets/kfileitemactions.cpp<br />

src/widgets/kfileitemactions.h<br />

src/widgets/kfileitemdelegate.cpp<br />

src/widgets/kfileitemdelegate.h<br />

src/widgets/kopenwithdialog.cpp<br />

src/widgets/kopenwithdialog.h<br />

src/widgets/kopenwithdialog_p.h<br />

src/widgets/kpropertiesdialog.cpp<br />

src/widgets/kpropertiesdialog.h<br />

src/widgets/krun.cpp<br />

src/widgets/ksslcertificatebox.h<br />

src/widgets/ksslinfodialog.h<br />

src/widgets/kurifilter.cpp<br />

src/widgets/kurifilter.h<br />

src/widgets/kurlcombobox.cpp<br />

src/widgets/kurlcombobox.h<br />

src/widgets/kurlcompletion.cpp<br />

src/widgets/kurlpixmapprovider.cpp<br />

src/widgets/kurlrequester.cpp<br />

src/widgets/kurlrequester.h<br />

src/widgets/kurlrequesterdialog.h<br />

src/widgets/paste.cpp<br />

src/widgets/pastejob.cpp<br />

src/widgets/pixmaploader.h<br />

src/widgets/previewjob.cpp<br />

src/widgets/previewjob.h<br />

src/widgets/renamedialog.cpp<br />

src/widgets/skipdialog.cpp<br />

src/widgets/sslui.cpp<br />

src/widgets/thumbcreator.cpp<br />

tests/kdirlistertest_gui.cpp<br />

tests/kdirlistertest_gui.h<br />

tests/kdirmodeltest_gui.cpp<br />

tests/kioslavetest.cpp<br />

tests/kopenwithtest.cpp<br />

tests/kruntest.cpp<br />

tests/ksycocaupdatetest.cpp<br />

tests/kurlnavigatortest_gui.cpp<br />

tests/listjobtest.cpp<br />

tests/listrecursivetest.cpp</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kfunk, Frameworks<br /></div>