Minimum required cmake version

Sven Brauch mail at svenbrauch.de
Tue Jan 3 13:16:02 UTC 2017


On 03/01/17 14:13, David Faure wrote:
>> No objection.
> 
> I do, however, have an objection to untested commits.
> 
> Sven, your commits broke knewstuff and some other modules.
> 
> CMake Error at /d/kde/inst/kde_frameworks/share/ECM/modules/
> ECMGeneratePriFile.cmake:137 (message):
>   Required variable PROJECT_VERSION_STRING not set before
>   ECM_GENERATE_PRI_FILE() call.  Did you call ecm_setup_version?
> Call Stack (most recent call first):
>   src/core/CMakeLists.txt:94 (ecm_generate_pri_file)
> 
> Changing the min required cmake version also changes the default values for a 
> number of cmake policies, so you need to adjust the cmakelists.txt 
> accordingly.

I'm sorry. I completely forgot changing the minimum cmake version
changes these defaults (and thus actually affects behaviour). I'll look
into it right now.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170103/ef3ec85b/attachment.sig>


More information about the Kde-frameworks-devel mailing list