Minimum required cmake version

[David Faure]

On lundi 2 janvier 2017 10:43:37 CET David Faure wrote:
> On lundi 2 janvier 2017 03:50:06 CET Aleix Pol wrote:
> > On Sat, Dec 31, 2016 at 7:16 PM, Michael Pyne <mpyne at kde.org> wrote:
> > > On Sat, Dec 31, 2016 at 03:47:00PM +0100, Sven Brauch wrote:
> > >> Hey,
> > >> 
> > >> On 27/12/16 19:30, Aleix Pol wrote:
> > >> > +1 on changing to 3.0.
> > >> 
> > >> Thanks for your opinion on the matter. I also think we should just bump
> > >> it, 3.0 is old enough -- as said it's even easily available on CentOS
> > >> 6.
> > >> 
> > >> Question is, should I change it on _all_ frameworks or just those using
> > >> Q_GADGET (i.e. those which actually need cmake 3)?
> > > 
> > > If we change the CMake requirement for one framework it should be
> > > changed for them all.  They are tested, released, and supported as a
> > > unit even though they have separate tiers and could theoretically be put
> > > together in a piecemeal fashion.
> > > 
> > > There might also be an easy way to change it in extra-cmake-modules but
> > > I think some of the buildsystem devs would know more about that.
> > > 
> > > Regards,
> > > 
> > >  - Michael Pyne
> > 
> > +1
> 
> No objection.

I do, however, have an objection to untested commits.

Sven, your commits broke knewstuff and some other modules.

CMake Error at /d/kde/inst/kde_frameworks/share/ECM/modules/
ECMGeneratePriFile.cmake:137 (message):
  Required variable PROJECT_VERSION_STRING not set before
  ECM_GENERATE_PRI_FILE() call.  Did you call ecm_setup_version?
Call Stack (most recent call first):
  src/core/CMakeLists.txt:94 (ecm_generate_pri_file)

Changing the min required cmake version also changes the default values for a 
number of cmake policies, so you need to adjust the cmakelists.txt 
accordingly.

(Do not just set the policies to OLD, that's the wrong way to go)

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5