[Differential] [Commented On] D4690: Import remote ioslave from plasma-workspace

[David Faure]

dfaure added a comment.


  Looks good to me, just found two more minor things.

INLINE COMMENTS

> remoteimpl.cpp:31
> +
> +#include <sys/stat.h>
> +

probably unused at this point

> remoteimpl.cpp:87
> +        QDir dir = *dirpath;
> +        if (!dir.exists()) {
> +            continue;

The QDir object and this check are now redundant. It's all covered by the QFileInfo::exists check below.

REPOSITORY
  R241 KIO

BRANCH
  import-remote

REVISION DETAIL
  https://phabricator.kde.org/D4690

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, dfaure, davidedmundson
Cc: ltoscano, #plasma, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170222/f390f0a6/attachment.html>