[Differential] [Commented On] D4637: KColorScheme: read application's KDE_COLOR_SCHEME_PATH property

Martin Gräßlin noreply at phabricator.kde.org
Fri Feb 17 13:48:02 UTC 2017


graesslin added inline comments.

INLINE COMMENTS

> kcolorscheme.h:316-318
> +     * from the given KConfig. If null, the application's KDE_COLOR_SCHEME_PATH
> +     * property will be used to load a KConfig. If this is also unset, the
> +     * system colors will be used.

I wouldn't mention the property name - that can be considered an implementation detail. Maybe instead something like "If a color scheme got installed with a KColorSchemeManager that one is used".

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D4637

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: flherne, #frameworks
Cc: graesslin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170217/0d4702fa/attachment.html>


More information about the Kde-frameworks-devel mailing list