[Differential] [Changed Subscribers] D4584: KDirWatch: replace QList<Client *> by std::vector<Client> to save on new/delete.

Sergio Martins noreply at phabricator.kde.org
Wed Feb 15 19:46:13 UTC 2017


smartins added inline comments.

INLINE COMMENTS

> kdirwatch.cpp:1379
>  
> -    Q_FOREACH (Client *c, e->m_clients) {
> -        if (c->instance == nullptr || c->count == 0) {
> +    for (Client &c : e->m_clients) {
> +        if (c.instance == nullptr || c.count == 0) {

can m_clients be shared ? If yes, htis detaches

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, aacid, mpyne, mwolff
Cc: smartins, mwolff, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170215/c4568760/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list