[Differential] [Accepted] D4584: KDirWatch: replace QList<Client *> by std::vector<Client> to save on new/delete.

[Milian Wolff]

mwolff accepted this revision.
mwolff added a reviewer: mwolff.
mwolff added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dfaure wrote in kdirwatch_p.h:84
> Given that the same thing happens by default, what would be the reason to make it explicit?

right, but that's what you want to state here, no? anyhow, I'm also OK with leaving it as-is

> dfaure wrote in kdirwatch_p.h:141
> The fact that it *can* be copied, doesn't mean that it's better to copy, performance wise ;)

so it's not just a cheap handle? ok then, leave it as is and hope the returned list is never stored anywhere

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4584

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: dfaure, aacid, mpyne, mwolff
Cc: mwolff, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170215/8cdc0318/attachment.html>