[Differential] [Accepted] D4448: Don't use tier3 frameworks in unit tests

Harald Sitter noreply at phabricator.kde.org
Tue Feb 14 10:47:14 UTC 2017


sitter accepted this revision.
sitter added a comment.


  Ah! I hadn't even thought of QSettings. Love the change.
  
  FWIW if you fancy more work: seeing as the test now has its own enums you could align the Context enum values' names with their string representation allowing `parseContext` to work like `parseType` by letting the metaobject do the mapping.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D4448

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: svuorela, vonreth, kde-frameworks-devel, dfaure, sitter
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170214/eb62ba2c/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list