<table><tr><td style="">sitter accepted this revision.<br />sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4448" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Ah! I hadn't even thought of QSettings. Love the change.</p>
<p>FWIW if you fancy more work: seeing as the test now has its own enums you could align the Context enum values' names with their string representation allowing <tt style="background: #ebebeb; font-size: 13px;">parseContext</tt> to work like <tt style="background: #ebebeb; font-size: 13px;">parseType</tt> by letting the metaobject do the mapping.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R266 Breeze Icons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4448" rel="noreferrer">https://phabricator.kde.org/D4448</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>svuorela, vonreth, kde-frameworks-devel, dfaure, sitter<br /><strong>Cc: </strong>Frameworks<br /></div>