Review Request 129921: [kio-extras] thumbnails should be a clean image representation without "hard-coded" borders or design elements

[David Faure]

> On Feb. 5, 2017, 9:50 a.m., David Faure wrote:
> > Can you also deprecate DrawFrame, then?
> 
> Diego S. wrote:
>     How does stuff get deprecated in Frameworks? I don't have a lot of kde development (or development in general) experience. I also don't have a proper dev environment setup atm.

In general, with nifty *_DEPRECATED macros. But for enums I'm not sure, so I did this, please check if what I wrote is correct:

https://commits.kde.org/kio/8d9fde5daede2315a1d45052828c70f1496210a5


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129921/#review102402
-----------------------------------------------------------


On Feb. 4, 2017, 9:51 p.m., Diego S. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129921/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2017, 9:51 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> -------
> 
> This patch is part of https://git.reviewboard.kde.org/r/129918/ - see the discussion on the old patch https://git.reviewboard.kde.org/r/118961/.
> 
> Many thumbnail generators currently return ThumbCreator::DrawFrame in their flags() function which causes a 90's style 1px "3d" border to be added to the thumbnail image.
> This causes problems when consumers of these thumbnails (like Dolphin) expect a clean image representation of the file, without hard-coded design elements.
> It also looks really bad when any resizing/scaling happens or when the thumbnail is shown on a tooltip. Especially now that the UI has been modernized with Breeze.
> 
> 
> Diffs
> -----
> 
>   thumbnail/comiccreator.cpp d8f4473e1c7fa4595ad8defc406ad945d1ac38ac 
>   thumbnail/djvucreator.cpp 1547831bfaa875a14a59659a2bebc86a2cd7c024 
>   thumbnail/htmlcreator.cpp 29d1902794abfa3cf8ba2ab97648e1bc2d8e7a73 
>   thumbnail/kritacreator.cpp 3b24bc3d2fa7b22662c25da1421cbd542d7efed6 
>   thumbnail/textcreator.cpp 7c0263c8e8cb4f88d1429b5714c51c2939d817f0 
> 
> Diff: https://git.reviewboard.kde.org/r/129921/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Diego S.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170206/4cecc805/attachment.html>