<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129921/">https://git.reviewboard.kde.org/r/129921/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 5th, 2017, 9:50 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can you also deprecate DrawFrame, then?</p></pre>
</blockquote>
<p>On February 6th, 2017, 5:01 a.m. UTC, <b>Diego S.</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How does stuff get deprecated in Frameworks? I don't have a lot of kde development (or development in general) experience. I also don't have a proper dev environment setup atm.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In general, with nifty *_DEPRECATED macros. But for enums I'm not sure, so I did this, please check if what I wrote is correct:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://commits.kde.org/kio/8d9fde5daede2315a1d45052828c70f1496210a5</p></pre>
<br />
<p>- David</p>
<br />
<p>On February 4th, 2017, 9:51 p.m. UTC, Diego S. wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Diego S..</div>
<p style="color: grey;"><i>Updated Feb. 4, 2017, 9:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is part of https://git.reviewboard.kde.org/r/129918/ - see the discussion on the old patch https://git.reviewboard.kde.org/r/118961/.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Many thumbnail generators currently return ThumbCreator::DrawFrame in their flags() function which causes a 90's style 1px "3d" border to be added to the thumbnail image.
This causes problems when consumers of these thumbnails (like Dolphin) expect a clean image representation of the file, without hard-coded design elements.
It also looks really bad when any resizing/scaling happens or when the thumbnail is shown on a tooltip. Especially now that the UI has been modernized with Breeze.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>thumbnail/comiccreator.cpp <span style="color: grey">(d8f4473e1c7fa4595ad8defc406ad945d1ac38ac)</span></li>
<li>thumbnail/djvucreator.cpp <span style="color: grey">(1547831bfaa875a14a59659a2bebc86a2cd7c024)</span></li>
<li>thumbnail/htmlcreator.cpp <span style="color: grey">(29d1902794abfa3cf8ba2ab97648e1bc2d8e7a73)</span></li>
<li>thumbnail/kritacreator.cpp <span style="color: grey">(3b24bc3d2fa7b22662c25da1421cbd542d7efed6)</span></li>
<li>thumbnail/textcreator.cpp <span style="color: grey">(7c0263c8e8cb4f88d1429b5714c51c2939d817f0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129921/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>