[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

[Albert Astals Cid]

aacid added a comment.


  In https://phabricator.kde.org/D4422#82848, @anthonyfieroni wrote:
  
  > > When subclassing QIODevice, you must call QIODevice::seek() at the start of your function to ensure integrity with QIODevice's built-in buffer.
  >
  > http://doc.qt.io/qt-5/qiodevice.html#seek
  >
  > For me, i'm not test it, it should be
  >
  >   if (!QIODevice::seek(pos)) {
  >           return false;
  >   }
  >   qint64 ioIndex = this->pos();
  >   .
  >   .
  >   .
  >
  
  
  No

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D4422

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aacid
Cc: anthonyfieroni, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170203/1aeee678/attachment-0001.html>