[Differential] [Commented On] D4422: Fix KCompressionDevice to work with Qt >= 5.7

[Anthony Fieroni]

anthonyfieroni added a comment.


  > When subclassing QIODevice, you must call QIODevice::seek() at the start of your function to ensure integrity with QIODevice's built-in buffer.
  
  http://doc.qt.io/qt-5/qiodevice.html#seek
  
  For me, i'm not test it, it should be
  
    if (!QIODevice::seek(pos)) {
            return false;
    }
    qint64 ioIndex = this->pos();
    .
    .
    .

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D4422

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: aacid
Cc: anthonyfieroni, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170203/ff3058cf/attachment.html>