D9453: Inform the user if the module can not be registered with org.kde.kded5 and exit with error

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  kded5 is supposed to be autostarted on demand by the DBus activation mechanism, but OK, if the setup is broken, I guess that might fail.

INLINE COMMENTS

> networkingservice.cpp:68
>      QDBusConnection::sessionBus().registerService( "org.kde.Solid.Networking.TestService" );
> +    if (!m_service->isValid())
> +        kError() << "could not register module" << m_service->path() << "at" << m_service->service();

KF5 coding style: { ... } even around 1-line bodies.

> networkingservice.cpp:69
> +    if (!m_service->isValid())
> +        kError() << "could not register module" << m_service->path() << "at" << m_service->service();
>  

kError() is deprecated, use qCritical()

> networkingservice.cpp:233
> +    {
> +        app.quit();
> +        return 1;

this line serves no purpose, since exec() wasn't even called.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D9453

To: habacker, dfaure
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171221/e211fb3d/attachment.html>