<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9453" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>kded5 is supposed to be autostarted on demand by the DBus activation mechanism, but OK, if the setup is broken, I guess that might fail.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9453#inline-42854" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">networkingservice.cpp:68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QDBusConnection</span><span style="color: #aa2211">::</span><span class="n">sessionBus</span><span class="p">().</span><span class="n">registerService</span><span class="p">(</span> <span style="color: #766510">"org.kde.Solid.Networking.TestService"</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_service</span><span style="color: #aa2211">-></span><span class="n">isValid</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">kError</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"could not register module"</span> <span style="color: #aa2211"><<</span> <span class="n">m_service</span><span style="color: #aa2211">-></span><span class="n">path</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"at"</span> <span style="color: #aa2211"><<</span> <span class="n">m_service</span><span style="color: #aa2211">-></span><span class="n">service</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">KF5 coding style: { ... } even around 1-line bodies.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9453#inline-42856" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">networkingservice.cpp:69</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">m_service</span><span style="color: #aa2211">-></span><span class="n">isValid</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">kError</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"could not register module"</span> <span style="color: #aa2211"><<</span> <span class="n">m_service</span><span style="color: #aa2211">-></span><span class="n">path</span><span class="p">()</span> <span style="color: #aa2211"><<</span> <span style="color: #766510">"at"</span> <span style="color: #aa2211"><<</span> <span class="n">m_service</span><span style="color: #aa2211">-></span><span class="n">service</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">kError() is deprecated, use qCritical()</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9453#inline-42853" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">networkingservice.cpp:233</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">app</span><span class="p">.</span><span class="n">quit</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">return</span> <span style="color: #601200">1</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this line serves no purpose, since exec() wasn't even called.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R239 KDELibs4Support</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9453" rel="noreferrer">https://phabricator.kde.org/D9453</a></div></div><br /><div><strong>To: </strong>habacker, dfaure<br /><strong>Cc: </strong>Frameworks<br /></div>