D9386: Mingw32 compile fix

Ralf Habacker noreply at phabricator.kde.org
Wed Dec 20 00:02:48 UTC 2017


habacker added a comment.


  In https://phabricator.kde.org/D9386#181227, @dfaure wrote:
  
  > If this wasn't kdelibs4support, I'd insist for sharing the implementation rather than duplicating it.
  
  
  Would be nice to share, but networking.cpp is only be used on non win32 platform, so how to share ?
  
  if(WIN32)
  
    set(libkdelibs4support_SRCS solid/networking_win.cpp
                                kdeui/kapplication_win.cpp)
  
  else()
  
    set(libkdelibs4support_SRCS solid/networking.cpp)
  
  endif()
  This came from KDE4  https://cgit.kde.org/kdelibs.git/commit/solid/solid/networking_p.h?h=KDE/4.14&id=1ad1f932d0af77326610dced17ad97b49f973f27

REPOSITORY
  R239 KDELibs4Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9386

To: habacker, dfaure, ltoscano, bcooksley
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171220/00bfea43/attachment.html>


More information about the Kde-frameworks-devel mailing list