<table><tr><td style="">habacker added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9386" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D9386#181227" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D9386#181227</a>, <a href="https://phabricator.kde.org/p/dfaure/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@dfaure</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>If this wasn't kdelibs4support, I'd insist for sharing the implementation rather than duplicating it.</p></div>
</blockquote>

<p>Would be nice to share, but networking.cpp is only be used on non win32 platform, so how to share ?</p>

<p>if(WIN32)</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">set(libkdelibs4support_SRCS solid/networking_win.cpp
                            kdeui/kapplication_win.cpp)</pre></div>

<p>else()</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">set(libkdelibs4support_SRCS solid/networking.cpp)</pre></div>

<p>endif()<br />
This came from KDE4  <a href="https://cgit.kde.org/kdelibs.git/commit/solid/solid/networking_p.h?h=KDE/4.14&id=1ad1f932d0af77326610dced17ad97b49f973f27" class="remarkup-link" target="_blank" rel="noreferrer">https://cgit.kde.org/kdelibs.git/commit/solid/solid/networking_p.h?h=KDE/4.14&id=1ad1f932d0af77326610dced17ad97b49f973f27</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R239 KDELibs4Support</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9386" rel="noreferrer">https://phabricator.kde.org/D9386</a></div></div><br /><div><strong>To: </strong>habacker, dfaure, ltoscano, bcooksley<br /><strong>Cc: </strong>Frameworks<br /></div>