D9123: reuse KPackage instance between PluginLoader and Applet

Marco Martin noreply at phabricator.kde.org
Fri Dec 8 11:22:34 UTC 2017


mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in applet.cpp:98
> If anyone uses the old argument list syntax (where the first argument was a string or a kpluginmetadata)  this will break.
> 
> Can we be sure that the PluginLoader was the only user? 
> It was a somewhat undocumented thing right?

yes, was completely undocumented.
it was the only user and safe-ish to assume it continues to as is protected

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9123

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171208/3ce0f113/attachment.html>


More information about the Kde-frameworks-devel mailing list