D9123: reuse KPackage instance between PluginLoader and Applet

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> applet.cpp:98
>      :  QObject(0),
> -       d(new AppletPrivate(KPluginMetaData(), args.count() > 1 ? args[1].toInt() : 0, this))
> +       d(new AppletPrivate(KPluginMetaData(), args.count() > 2 ? args[2].toInt() : 0, this))
>  {

If anyone uses the old argument list syntax (where the first argument was a string or a kpluginmetadata)  this will break.

Can we be sure that the PluginLoader was the only user? 
It was a somewhat undocumented thing right?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D9123

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171204/cf5c9f57/attachment.html>