D9128: [knewstuff] Respect global variable

[Michael Pyne]

mpyne accepted this revision.
mpyne added a comment.
This revision is now accepted and ready to land.


  I think the change looks good.  But if the cache here is holding a *weak* pointer to a `Cache` then every user of this s_cache should be checking for null pointers each time, right?  We can do the improved lifetime checking here but I think it would also have worked fine to check weak pointers before using them.  Though maybe weak pointers were just there to avoid circular references?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D9128

To: anthonyfieroni, leinir, dfaure, mpyne
Cc: mpyne, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171206/1290e82f/attachment.html>