D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> transferjob.cpp:310-323
>          if (m_extraFlags & JobPrivate::EF_TransferJobAsync) {
>              q->connect(m_outgoingDataSource, SIGNAL(readyRead()),
>                      SLOT(slotDataReqFromDevice()));
>              q->connect(m_outgoingDataSource, SIGNAL(readChannelFinished()),
>                      SLOT(slotIODeviceClosed()));
>              if (m_outgoingDataSource->bytesAvailable() > 0) {
>                  QMetaObject::invokeMethod(q, "slotDataReqFromDevice", Qt::QueuedConnection);

It looks very weird to me even with single invocation call. Does it better to connect outgoing source early, when we know that job is async?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9190

To: aacid, dfaure, apol, albertvaka
Cc: anthonyfieroni, nicolasfella, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20171205/9c1f4748/attachment.html>