<table><tr><td style="">anthonyfieroni added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9190" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9190#inline-41304" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">transferjob.cpp:310-323</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_extraFlags</span> <span style="color: #aa2211">&</span> <span class="n">JobPrivate</span><span style="color: #aa2211">::</span><span class="n">EF_TransferJobAsync</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">connect</span><span class="p">(</span><span class="n">m_outgoingDataSource</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">readyRead</span><span class="p">()),</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                    <span class="n">SLOT</span><span class="p">(</span><span class="n">slotDataReqFromDevice</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="n">q</span><span style="color: #aa2211">-></span><span class="n">connect</span><span class="p">(</span><span class="n">m_outgoingDataSource</span><span class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">readChannelFinished</span><span class="p">()),</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                    <span class="n">SLOT</span><span class="p">(</span><span class="n">slotIODeviceClosed</span><span class="p">()));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_outgoingDataSource</span><span style="color: #aa2211">-></span><span class="n">bytesAvailable</span><span class="p">()</span> <span style="color: #aa2211">></span> <span style="color: #601200">0</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">QMetaObject</span><span style="color: #aa2211">::</span><span class="n">invokeMethod</span><span class="p">(</span><span class="n">q</span><span class="p">,</span> <span style="color: #766510">"slotDataReqFromDevice"</span><span class="p">,</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">QueuedConnection</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It looks very weird to me even with single invocation call. Does it better to connect outgoing source early, when we know that job is async?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9190" rel="noreferrer">https://phabricator.kde.org/D9190</a></div></div><br /><div><strong>To: </strong>aacid, dfaure, apol, albertvaka<br /><strong>Cc: </strong>anthonyfieroni, nicolasfella, Frameworks<br /></div>