D7367: Added Intel HEX file support for the Syntax highlighting database

[Miklos Marton]

martonmiklos added a comment.


  In https://phabricator.kde.org/D7367#136687, @cullmann wrote:
  
  > Could you add a minimal example as unit test?
  
  
  Sure, I have just seen that these xmls could be autotested.
  
  > And could we have as license something like "MIT"?
  
  Sure, I have no objections about it.
  
  > For the coloring: it is preferred to use some of our default styles and no hard coded colors to make color schemes possible.
  
  
  
  In https://phabricator.kde.org/D7367#136817, @dhaumann wrote:
  
  > Please change the kateversion, and as Christoph mentioned please remove hard-coded colors. You can find a list of all valid default styles here: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
  
  
  Thanks for the tips, I will change the license, colors and add autotest.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7367

To: martonmiklos, #framework_syntax_hightlighting
Cc: dhaumann, cullmann, #frameworks, vkrause
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170817/b8982a95/attachment.html>