D7367: Added Intel HEX file support for the Syntax highlighting database

[Dominik Haumann]

dhaumann added a comment.


  Please change the kateversion, and as Christoph mentioned please remove hard-coded colors. You can find a list of all valid default styles here: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/

INLINE COMMENTS

> hex.xml:3
> +<!DOCTYPE language SYSTEM "language.dtd">
> +<language name="Intel HEX" section="Other" extensions="*.hex;*.ihx" version="1" kateversion="16.04" author="Miklos Marton (martonmiklosqdev at gmail.com)" license="LGPL">
> +  <highlighting>

kateversion 16.04 is not a valid number. Please change to kateversion="5.0"

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7367

To: martonmiklos, #framework_syntax_hightlighting
Cc: dhaumann, cullmann, #frameworks, vkrause
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170817/c48abe16/attachment.html>