D7279: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Sat Aug 12 19:25:12 UTC 2017
kossebau created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Nested classes inherit the visibility of their outer class,
so all the KClass::Private symbols have also been exported
if the ones of KClass were.
Best fix would be to change all pimpl classes to be non-nested,
but that needs a bigger patch as some nested classes directly
access types and properties of their outer classes.
Left to do for someone else :)
REPOSITORY
R236 KWidgetsAddons
BRANCH
dontleaksymbolsofpimplclasses
REVISION DETAIL
https://phabricator.kde.org/D7279
AFFECTED FILES
src/kassistantdialog.cpp
src/kcapacitybar.cpp
src/kcharselect.cpp
src/kcolorbutton.cpp
src/kdatepicker.cpp
src/kfontchooser.cpp
src/kfontrequester.cpp
src/kfontsizeaction.cpp
src/kled.cpp
src/kmimetypechooser.cpp
src/knewpassworddialog.cpp
src/knewpasswordwidget.cpp
src/kpagewidgetmodel.cpp
src/kpassworddialog.cpp
src/kpixmapregionselectordialog.cpp
src/kpixmapregionselectorwidget.cpp
src/kpixmapsequence.cpp
src/kpixmapsequenceoverlaypainter.cpp
src/kpixmapsequencewidget.cpp
src/kpopupframe.cpp
src/kratingpainter.cpp
src/kratingwidget.cpp
src/kselector.cpp
src/ksplittercollapserbutton.cpp
src/ktitlewidget.cpp
src/ktoggleaction.cpp
src/ktogglefullscreenaction.cpp
src/ktoolbarlabelaction.cpp
src/ktoolbarpopupaction.cpp
src/ktooltipwidget.cpp
src/kurllabel.cpp
src/kxyselector.cpp
To: kossebau, cfeck, dfaure, vkrause
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170812/b2e25051/attachment.html>
More information about the Kde-frameworks-devel
mailing list