<table><tr><td style="">kossebau created this revision.<br />Restricted Application added a project: Frameworks.<br />Restricted Application added a subscriber: Frameworks.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7279" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Nested classes inherit the visibility of their outer class,<br />
so all the KClass::Private symbols have also been exported<br />
if the ones of KClass were.</p>
<p>Best fix would be to change all pimpl classes to be non-nested,<br />
but that needs a bigger patch as some nested classes directly<br />
access types and properties of their outer classes.<br />
Left to do for someone else :)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R236 KWidgetsAddons</div></div></div><br /><div><strong>BRANCH</strong><div><div>dontleaksymbolsofpimplclasses</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7279" rel="noreferrer">https://phabricator.kde.org/D7279</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>src/kassistantdialog.cpp<br />
src/kcapacitybar.cpp<br />
src/kcharselect.cpp<br />
src/kcolorbutton.cpp<br />
src/kdatepicker.cpp<br />
src/kfontchooser.cpp<br />
src/kfontrequester.cpp<br />
src/kfontsizeaction.cpp<br />
src/kled.cpp<br />
src/kmimetypechooser.cpp<br />
src/knewpassworddialog.cpp<br />
src/knewpasswordwidget.cpp<br />
src/kpagewidgetmodel.cpp<br />
src/kpassworddialog.cpp<br />
src/kpixmapregionselectordialog.cpp<br />
src/kpixmapregionselectorwidget.cpp<br />
src/kpixmapsequence.cpp<br />
src/kpixmapsequenceoverlaypainter.cpp<br />
src/kpixmapsequencewidget.cpp<br />
src/kpopupframe.cpp<br />
src/kratingpainter.cpp<br />
src/kratingwidget.cpp<br />
src/kselector.cpp<br />
src/ksplittercollapserbutton.cpp<br />
src/ktitlewidget.cpp<br />
src/ktoggleaction.cpp<br />
src/ktogglefullscreenaction.cpp<br />
src/ktoolbarlabelaction.cpp<br />
src/ktoolbarpopupaction.cpp<br />
src/ktooltipwidget.cpp<br />
src/kurllabel.cpp<br />
src/kxyselector.cpp</div></div></div><br /><div><strong>To: </strong>kossebau, cfeck, dfaure, vkrause<br /><strong>Cc: </strong>Frameworks<br /></div>