D6833: Add support for PrivilegeExecution in KIO jobs

David Faure noreply at phabricator.kde.org
Fri Aug 11 21:01:45 UTC 2017


dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks OK to me now (just minor things)

INLINE COMMENTS

> copyjob.cpp:267
>  
> +    KIO::JobFlag privilegeExecFlag() { return m_privilegeExecutionEnabled ? PrivilegeExecution : DefaultFlags; }
> +

mark the method as const

> mkpathjob.cpp:131
>      Q_D(MkpathJob);
> +
>      if (job->error() && job->error() != KIO::ERR_DIR_ALREADY_EXIST) {

revert unnecessary newline changes to this file

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6833

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170811/fdd0873b/attachment.html>


More information about the Kde-frameworks-devel mailing list