D7164: KSqueezedTextLabel: Respect indent, margin and frame width

[Henrik F.]

rkflx added a comment.


  Some thoughts, inconclusive though:
  
  Another idea: Sometimes additional functionality for non-virtual functions is provided by hooking into the changeEvent(). However, for our use case we won't get such events from QLabel.
  
  Things we might want to consider when going with aggregation instead of inheritance regarding QLabel (which seems like the best solution so far):
  
  - Are there APIs or legacy users which can only take QLabels? (How to check without manually analyzing lxr search results?)
  - Which functions of QLabel and QFrame should we reimplement? (What is used? What semantics do not make sense? Also see TODO in autotest.)
  
  Ideal solution: Add virtual in Qt itself or make it a signal. Should we try and ask for Qt6? It has been done before: https://codereview.qt-project.org/#/c/111849/
  
  I wonder if there is a general best practice solution for this issue in KF5, e.g. when looking at the Qt4 → Qt5 BIC transition?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7164

To: rkflx, #frameworks
Cc: dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170810/06c445b8/attachment.html>