D7045: Remove busy loop check in TransferJobPrivate::slotDataReqFromDevice
David Faure
noreply at phabricator.kde.org
Wed Aug 9 07:41:44 UTC 2017
dfaure added a comment.
isn't this about the case where there is more data available than MAX_READ_BUF_SIZE, so we didn't read it all and we need to loop around to read the rest?
OK, that's not what the if says, but I think that's still one case where we need to loop. So maybe it should be
if (bytesRead == MAX_READ_BUF_SIZE) {
QIODevice doesn't emit readyRead() again if it notified us about 16K being available and we only read 8K.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7045
To: aacid
Cc: dfaure, apol, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170809/b3eafdaf/attachment.html>
More information about the Kde-frameworks-devel
mailing list