<table><tr><td style="">dfaure added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D7045" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>isn't this about the case where there is more data available than MAX_READ_BUF_SIZE, so we didn't read it all and we need to loop around to read the rest?<br />
OK, that's not what the if says, but I think that's still one case where we need to loop. So maybe it should be</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (bytesRead == MAX_READ_BUF_SIZE) {</pre></div>
<p>QIODevice doesn't emit readyRead() again if it notified us about 16K being available and we only read 8K.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D7045" rel="noreferrer">https://phabricator.kde.org/D7045</a></div></div><br /><div><strong>To: </strong>aacid<br /><strong>Cc: </strong>dfaure, apol, Frameworks<br /></div>