D6831: Make use of kauth helper in methods of file ioslave

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Please resubmit with context.
  
  Also, did you check that unittests still pass? No kauth prompt should occur :-)

INLINE COMMENTS

> file.cpp:242
>  #if defined(ENOTSUP)
> -        case ENOTSUP: // from setACL since chmod can't return ENOTSUP
> -            error(KIO::ERR_UNSUPPORTED_ACTION, i18n("Setting ACL for %1", path));
> -            break;
> +            case ENOTSUP: // fro setACL since chmod can't return ENOTSUP
> +                error(KIO::ERR_UNSUPPORTED_ACTION, i18n("Setting ACL for %1", path));

the 'm' in "from" was actually good looking there :)

> file.cpp:296
> +        if (!dirCreated)
> +            dirCreated = execWithElevatedPrivilege(errno, MKDIR, path);
> +

Picking this random one as an example:

- what happens if the user cancels the root-password prompt? He will then get another msg box with "cannot create directory?" even though he/she purposefully canceled the operation? When that happens the slave should use error(KIO::ERR_USER_CANCELED) instead (which means no error box), but of course only in that case...

> file.cpp:629
>  
> +
>                  if ((_flags & KIO::Resume)) {

remove new empty line, there's already one

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D6831

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170804/a88ffd96/attachment-0001.html>