<table><tr><td style="">dfaure requested changes to this revision.<br />dfaure added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6831" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Please resubmit with context.</p>
<p>Also, did you check that unittests still pass? No kauth prompt should occur :-)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6831#inline-29090" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">file.cpp:242</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">#if defined(ENOTSUP)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span style="color: #a0a000">ENOTSUP</span><span class="p">:</span> <span style="color: #74777d">// fro<span class="bright">m</span> setACL since chmod can't return ENOTSUP</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">error</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">ERR_UNSUPPORTED_ACTION</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Setting ACL for %1"</span><span class="p">,</span> <span class="n">path</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #aa4000">case</span> <span style="color: #a0a000">ENOTSUP</span><span class="p">:</span> <span style="color: #74777d">// fro setACL since chmod can't return ENOTSUP</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span class="n">error</span><span class="p">(</span><span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">ERR_UNSUPPORTED_ACTION</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Setting ACL for %1"</span><span class="p">,</span> <span class="n">path</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">the 'm' in "from" was actually good looking there :)</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6831#inline-29092" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">file.cpp:296</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">dirCreated</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">dirCreated</span> <span style="color: #aa2211">=</span> <span class="n">execWithElevatedPrivilege</span><span class="p">(</span><span class="n">errno</span><span class="p">,</span> <span class="n">MKDIR</span><span class="p">,</span> <span class="n">path</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Picking this random one as an example:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">what happens if the user cancels the root-password prompt? He will then get another msg box with "cannot create directory?" even though he/she purposefully canceled the operation? When that happens the slave should use error(KIO::ERR_USER_CANCELED) instead (which means no error box), but of course only in that case...</li>
</ul></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6831#inline-28415" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">file.cpp:629</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">((</span><span class="n">_flags</span> <span style="color: #aa2211">&</span> <span class="n">KIO</span><span style="color: #aa2211">::</span><span class="n">Resume</span><span class="p">))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">remove new empty line, there's already one</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R241 KIO</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6831" rel="noreferrer">https://phabricator.kde.org/D6831</a></div></div><br /><div><strong>To: </strong>chinmoyr, dfaure, Frameworks<br /><strong>Cc: </strong>Frameworks<br /></div>