D7011: Extract KPasswordLineEdit class

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kfunk wrote in kpasswordlineedit.cpp:30
> +1. Don't use nested private classes. Nested classes/structs inherit the symbols visibility.
> 
> Also see: https://phabricator.kde.org/D6927
> 
> PS: In times of Qt5 & lambda-connects, you don't need Q_PRIVATE_SLOT anymore, anyway: 
> Just remove the `Q_PRIVATE_SLOT` marker and ...:
> `connect(..., this, [this](...) { d->myPrivateSlot(...); });`

Oh, that would make a nice "junior job" to get those cleaned out everywhere. Is removing a private slot considered API/ABI compatible?

REVISION DETAIL
  https://phabricator.kde.org/D7011

To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kfunk, kossebau, elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170803/6f14306b/attachment.html>