D7011: Extract KPasswordLineEdit class

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kpasswordlineedit.cpp:3
> +   Copyright (c) 2017 Montel Laurent <montel at kde.org>
> +
> +   This library is free software; you can redistribute it and/or modify

Elvis, you wrote the "visibilityAction" stuff, right? If yes, needs to be mentioned here.

> kpasswordlineedit.cpp:26
> +#include <QHBoxLayout>
> +#include <QLineEdit>
> +#include <QDebug>

QLineEdit is included in the .h file, can be removed here.

> kpasswordlineedit.cpp:36
> +    {
> +
> +    }

Remove empty line.

> kpasswordlineedit.cpp:60
> +
> +
> +    q->connect(toggleEchoModeAction, &QAction::triggered, q, [this]() {_k_echoModeToggled();});

Remove doubled empty line.

> kpasswordlineedit.cpp:116
> +    d->passwordLineEdit->setText(password);
> +    Q_EMIT passwordChanged(password);
> +}

Does this need a protection for not emitting if the value did not actually change? I think it helps to prevent recursion.

REVISION DETAIL
  https://phabricator.kde.org/D7011

To: mlaurent, cfeck, dfaure, elvisangelaccio
Cc: kfunk, kossebau, elvisangelaccio, #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170803/36fd0d18/attachment.html>