D5557: fix basename handling of po files

Aleix Pol Gonzalez noreply at phabricator.kde.org
Mon Apr 24 16:19:23 UTC 2017


apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Lgtm, thanks for the test!

INLINE COMMENTS

> build-pofiles.cmake:35
> +    # https://bugs.kde.org/show_bug.cgi?id=379116
> +    string(REGEX REPLACE "^(.+)(\\.[^.]+)$" "\\1" name ${name})
>      get_filename_component(langdir ${pofile} DIRECTORY)

You don't need the second set of ()

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5557

To: sitter, apol, ilic
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170424/62c185bc/attachment.html>


More information about the Kde-frameworks-devel mailing list