D5557: fix basename handling of po files

Harald Sitter noreply at phabricator.kde.org
Mon Apr 24 07:58:18 UTC 2017


sitter created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  get_filename_component(... ... NAME_WE) gets the name without the *longest*
  extension. in case of 'org.kde.plasma.kittens.po' that would leave us
  with 'org' as name. Use a regular expression to grab the basename without
  the short extension (e.g. 'org.kde.plasma.kittens') to prevent broken file
  names.
  
  add a test to assert that this works in the future
  
  BUG: 379116

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5557

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/ki18n_install/CMakeLists.txt
  autotests/ki18n_install/po/de/plasma_applet_org.kde.plasma.katesessions.po
  autotests/ki18n_install/test.cmake
  cmake/build-pofiles.cmake

To: sitter, apol, ilic
Cc: #frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170424/2c181af2/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list