D5394: KAuth integration in document saving - vol. 2

[Fabian Vogt]

fvogt added a comment.


  Thanks again!
  The changes look good, but strace shows that the QFile operation still use absolute paths, apparently it resolves the "." manually with getcwd:
  
    chdir("/tmp")                           = 0
    stat("/tmp/permfile", {st_mode=S_IFREG|0644, st_size=5, ...}) = 0
    open("/tmp/kate.X31571", O_RDONLY|O_CLOEXEC) = 11
    fstat(11, {st_mode=S_IFREG|0600, st_size=14, ...}) = 0
    getcwd("/tmp", 4096)                    = 5
    open("/tmp/permfile.J31580", O_RDWR|O_CREAT|O_EXCL|O_CLOEXEC, 0600) = 12
    [...]
    stat("/tmp/permfile", {st_mode=S_IFREG|0644, st_size=5, ...}) = 0
    chmod("/tmp/permfile.J31580", 0644)     = 0
    fchown(12, 0, 0)                        = 0
    rename("permfile.J31580", "permfile")
  
  
  
  >   ...this looks like a bug in KAuth since I only should get job->exec() result when my particular job was finished. I tried to differentiate the jobs by returning a unique data in reply.data() map and retrieving them in job->data() map, but that does not work either (another bug?). I'll try to investigate KAuth code further and report/propose-fix in proper facilities :).
  
  Yup, looks like a KAuth bug to me as well.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5394

To: martinkostolny, #ktexteditor, fvogt
Cc: elvisangelaccio, aacid, ivan, lbeltrame, fvogt, apol, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, dfaure, #frameworks, head7, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170420/6add6dbd/attachment-0001.html>