D5394: KAuth integration in document saving - vol. 2

[Martin Kostolný]

martinkostolny updated this revision to Diff 13621.
martinkostolny added a comment.


  Understood and implemented by switching to "current directory" where the final rename is taking place. This way I could use filenames only rename. Hopefully I didn't miss anything.
  
  One other issue I've noticed during testing:
  
  - open Kate to edit a privileged file1
  - open KWrite to edit a different privileged file2
  - edit & save file1 (do not enter password yet)
  - edit & save file2 -> it seems nothing happens
  - fill password to existing KAuth dialog and send -> both editors say "saved", although only the first one is really saved
  
  ...this looks like a bug in KAuth since I only should get job->exec() result when my particular job was finished. I tried to differentiate the jobs by returning a unique data in reply.data() map and retrieving them in job->data() map, but that does not work either (another bug?). I'll try to investigate KAuth code further and report/propose-fix in proper facilities :).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5394?vs=13539&id=13621

REVISION DETAIL
  https://phabricator.kde.org/D5394

AFFECTED FILES
  src/buffer/katesecuretextbuffer.cpp
  src/buffer/katesecuretextbuffer_p.h
  src/buffer/katetextbuffer.cpp
  src/buffer/katetextbuffer.h

To: martinkostolny, #ktexteditor, fvogt
Cc: elvisangelaccio, aacid, ivan, lbeltrame, fvogt, apol, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, dfaure, #frameworks, head7, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170419/5a01c9b0/attachment-0001.html>