D5439: API dox: more info about KAboutData's orgDomain/desktopFileName properties

[Luigi Toscano]

ltoscano requested changes to this revision.
ltoscano added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kaboutdata.cpp:689
>  
>  KAboutData &KAboutData::setOrganizationDomain(const QByteArray &domain)
>  {

I would add something like
// KF6: if desktopFileName has not been explicitly set, set it to domain + component name

> kaboutdata.h:314
> + * // create the aboutData instance
> + * KAboutData aboutData("foo", i18n("Foo"), "0.1",
> + *                      i18n("To Foo or not To Foo"),

The QApplication instance should happen before this line, not just before setApplicationData (that's what Albert was trying to explain).

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D5439

To: kossebau, #frameworks, stikonas, mpyne, aacid, ltoscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170413/cf6b697f/attachment.html>