D5394: KAuth integration in document saving - vol. 2

[Fabian Vogt]

fvogt added a comment.


  Looks good!
  
  > should I make a checksum of the data before sending to KAuth action and then match it with checksum sent back by the action?
  
  Yes, that way you could also implement a way to show the checksum to the user. Make sure to avoid any TOCTTOU issues.
  
  I see the code for changing the permissions is still there, what are the permissions of the temporary file that QSaveFile creates?
  It mustn't be something other than 0600 (-rw----).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5394

To: martinkostolny, #ktexteditor
Cc: elvisangelaccio, aacid, ivan, lbeltrame, fvogt, apol, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, dfaure, #frameworks, head7, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170411/4543bfa6/attachment.html>