D5394: KAuth integration in document saving - vol. 2

[Martin Kostolný]

martinkostolny created this revision.
martinkostolny added projects: KTextEditor, Frameworks.
Restricted Application added subscribers: Frameworks, kwrite-devel.

REVISION SUMMARY
  This is a follow-up of https://phabricator.kde.org/D4847, trying to fix issues pointed out by Fabian:
  
  - send the whole document content to KAuth action
  - therefore permissions are not changed to a new file after its creation
  
  There are a few questions / missing features:
  
  - should I make a checksum of the data before sending to KAuth action and then match it with checksum sent back by the action?
  - how do we handle big files?
    - dbus default is 32MiB so I limited the sent data to 30MiB
    - but dbus can probably be configured to allow less
    - I'm not aware of a different way to send the data to the helper process, any ideas? Or is it OK, as it is?

TEST PLAN
  in Kate:
  
  - edit a regular file
  - edit a file of a root user
  - edit a file of a different user (check that owner is preserved)
  - open, write and save a new file in a folder owned by root

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D5394

AFFECTED FILES
  autotests/src/katetextbuffertest.cpp
  src/buffer/katesecuretextbuffer.cpp
  src/buffer/katesecuretextbuffer_p.h
  src/buffer/katetextbuffer.cpp
  src/buffer/katetextbuffer.h

To: martinkostolny, #ktexteditor
Cc: elvisangelaccio, aacid, ivan, lbeltrame, fvogt, apol, anthonyfieroni, cullmann, ltoscano, dhaumann, graesslin, davidedmundson, palant, kwrite-devel, dfaure, #frameworks, head7, kfunk, sars
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20170411/5c5570ee/attachment-0001.html>