Review Request 129010: kded: remove dbus calls to ksplash.

[Luigi Toscano]

> On Set. 24, 2016, 2:15 p.m., Luigi Toscano wrote:
> > Wouldn't this break the compatibility with older Plasma (one can argue that Plasma should be updated, but it's a behavioral change).
> 
> David Faure wrote:
>     Yes it would. Can you suggest an appropriate time frame for this cleanup? I was hoping two plasma releases (5.7 and 5.8) was OK, I can wait more, but I'd like to keep cleaning up kded from workspace stuff at some point, it really doesn't belong there.

I don't have an answer. it boils down to the promise of binary compatibility in Frameworks. If it includes behavioral compatibility, this couldn't theoretically be changed in the lifetime of 5. That said, I guess that the only user of this specific change is Plasma, so this specific case could be a really specific exception which would be announced making sure that it's well known.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129010/#review99501
-----------------------------------------------------------


On Set. 24, 2016, 2:09 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129010/
> -----------------------------------------------------------
> 
> (Updated Set. 24, 2016, 2:09 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kded
> 
> 
> Description
> -------
> 
> Not needed anymore since June (b6058a0 in plasma-workspace, i.e. Plasma 5.7).
> 
> 
> Diffs
> -----
> 
>   src/kded.cpp 6b3ec1e93f5c1ae3620204190af2c8cee3736a11 
> 
> Diff: https://git.reviewboard.kde.org/r/129010/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20160925/010a3736/attachment-0001.html>